[middleware](Placeholder) Significantly improve perf when log message…

… not contains % char (#83)
gol4ng · Feb 17, 2023 · 4892eb1 · 4892eb1
1 parent 7dac5ee
commit 4892eb1
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/middleware/benchmark_test.go b/middleware/benchmark_test.go
@@ -55,6 +55,16 @@ func getEntries() []logger.Entry {
 				Add("my_key4", "my_value4").
 				Add("my_key5", "my_value5"),
 		},
+		{
+			Message: "test message",
+			Level:   logger.WarningLevel,
+			Context: logger.NewContext().
+				Add("my_key", "my_value").
+				Add("my_key2", "my_value2").
+				Add("my_key3", "my_value3").
+				Add("my_key4", "my_value4").
+				Add("my_key5", "my_value5"),
+		},
 	}
 }
 

diff --git a/middleware/placeholder.go b/middleware/placeholder.go
@@ -10,7 +10,7 @@ import (
 func Placeholder() logger.MiddlewareInterface {
 	return func(handler logger.HandlerInterface) logger.HandlerInterface {
 		return func(entry logger.Entry) error {
-			if entry.Context != nil {
+			if entry.Context != nil && strings.Contains(entry.Message, "%") {
 				msg := entry.Message
 				for n, f := range *entry.Context {
 					msg = strings.Replace(msg, "%"+n+"%", f.String(), -1)