Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: Typo fixes #13455

Merged
merged 1 commit into from
Feb 26, 2025
Merged

all: Typo fixes #13455

merged 1 commit into from
Feb 26, 2025

Conversation

coliff
Copy link
Member

@coliff coliff commented Feb 26, 2025

No description provided.

@coliff
Copy link
Member Author

coliff commented Feb 26, 2025

@bep there's a few typos in files in the hugolib folder, but did you mention at some point a while back that changes shouldn't be made to files in there? .. or if you want I can add the below fixes to this PR too.

image
image

@bep
Copy link
Member

bep commented Feb 26, 2025

This is good, but it would be even better if you could get the commit message title in line with the guidelines, especially since the commit itself is about language correctness.

@coliff coliff changed the title all: typo fixes all: Typo fixes Feb 26, 2025
@bep
Copy link
Member

bep commented Feb 26, 2025

hugolib folder, but did you mention at some point a while back that changes

That was back when I had a "full rewrite" of that package living in a branch, which would have made spelling fixes a real pain to merge in.

Also, to fix the commit message you need to amend your commit (the PR title is a different title). I could certainly do it when merging this, but it would save some future hassle to get the setup ... right.

@coliff
Copy link
Member Author

coliff commented Feb 26, 2025

ok sounds good. I'll add those others I found in /hugolib and amend the commit to match the PR title all: Typo fixes - is that ok?

@coliff coliff force-pushed the dev/coliff/typos-fix branch from c150023 to 28bb2cd Compare February 26, 2025 13:24
@bep bep merged commit 4094a1e into gohugoio:master Feb 26, 2025
6 checks passed
@coliff coliff deleted the dev/coliff/typos-fix branch February 26, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants