build docker images with deploy capability #13436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This change is currently untested, as I have no good way to properly test if the pipeline working as expected inside the fork. |
|
This does not look like my comment in #13435 (comment) ... I would expect the change set to be ... smaller (e.g. add a tag to the existing build command). |
margau
force-pushed
the
feat/docker-deploy
branch
from
729af52 to
cc0edfa
Compare
Sorry, misunderstood the comment - adjusted the PR accordingly, it just adds the build arg now - no separate image variants. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PRs adds one variant of the functionality proposed in #13435:
The Image is built using the "withdeploy" build tag, enabling deploy capability in all containers.