Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration issue with UI #21619

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stonezdj
Copy link
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner February 11, 2025 05:37
@stonezdj stonezdj added the release-note/enhancement Label to mark PR to be added under release notes as enhancement label Feb 11, 2025
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.17%. Comparing base (c8c11b4) to head (2501e26).
Report is 382 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #21619      +/-   ##
==========================================
+ Coverage   45.36%   46.17%   +0.80%     
==========================================
  Files         244      247       +3     
  Lines       13333    13883     +550     
  Branches     2719     2875     +156     
==========================================
+ Hits         6049     6410     +361     
- Misses       6983     7135     +152     
- Partials      301      338      +37     
Flag Coverage Δ
unittests 46.17% <ø> (+0.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 491 files with indirect coverage changes

@stonezdj stonezdj force-pushed the 25feb11_fix_integration_ui branch 3 times, most recently from e481923 to da7f872 Compare February 13, 2025 08:31
Signed-off-by: stonezdj <stone.zhang@broadcom.com>
@stonezdj stonezdj force-pushed the 25feb11_fix_integration_ui branch from da7f872 to 2501e26 Compare February 13, 2025 09:24
@stonezdj
Copy link
Contributor Author

already merge commit with the pr #21608

@stonezdj stonezdj marked this pull request as draft February 17, 2025 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/enhancement Label to mark PR to be added under release notes as enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants