Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update purge audit to purge both audit_log_ext and audit_log #21608

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

stonezdj
Copy link
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.11%. Comparing base (c8c11b4) to head (841b4a6).
Report is 390 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #21608      +/-   ##
==========================================
+ Coverage   45.36%   46.11%   +0.74%     
==========================================
  Files         244      247       +3     
  Lines       13333    13883     +550     
  Branches     2719     2875     +156     
==========================================
+ Hits         6049     6402     +353     
- Misses       6983     7143     +160     
- Partials      301      338      +37     
Flag Coverage Δ
unittests 46.11% <ø> (+0.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 491 files with indirect coverage changes

@stonezdj stonezdj force-pushed the 25feb10_purge_audit branch 2 times, most recently from b972aa9 to ad80c9a Compare February 10, 2025 06:39
@stonezdj stonezdj force-pushed the 25feb10_purge_audit branch 5 times, most recently from 3acf09a to 01acf6e Compare February 17, 2025 02:39
@stonezdj stonezdj mentioned this pull request Feb 17, 2025
5 tasks
@stonezdj stonezdj force-pushed the 25feb10_purge_audit branch from cd9339d to a55c8a7 Compare February 17, 2025 06:53
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

  Fix integration issue with UI

Signed-off-by: stonezdj <stone.zhang@broadcom.com>
@stonezdj stonezdj force-pushed the 25feb10_purge_audit branch from a55c8a7 to 841b4a6 Compare February 18, 2025 09:09
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj enabled auto-merge (squash) February 18, 2025 09:18
@stonezdj stonezdj merged commit 4565907 into goharbor:main Feb 18, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/new-feature New Harbor Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants