Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] Fix Incorrect Data Display in Replications Table (#21461) #21604

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

bupd
Copy link
Contributor

@bupd bupd commented Feb 9, 2025

Thank you for contributing to Harbor!

Comprehensive Summary of your change

  • fix incorrect data display in replications table

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/update"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

fix incorrect data display in replications table

Signed-off-by: bupd <bupdprasanth@gmail.com>
@bupd bupd requested a review from a team as a code owner February 9, 2025 04:01
Copy link

codecov bot commented Feb 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-2.12.0@73072d0). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-2.12.0   #21604   +/-   ##
=================================================
  Coverage                  ?   66.08%           
=================================================
  Files                     ?     1049           
  Lines                     ?   114656           
  Branches                  ?     2867           
=================================================
  Hits                      ?    75771           
  Misses                    ?    34738           
  Partials                  ?     4147           
Flag Coverage Δ
unittests 66.08% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@stonezdj stonezdj added the release-note/update Update or Fix label Feb 10, 2025
@reasonerjt reasonerjt merged commit 7a64a14 into goharbor:release-2.12.0 Feb 10, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants