Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppresses net/http AbortHandler panic as per Go instructions #21478

Closed
wants to merge 10 commits into from

Conversation

ianseyer
Copy link

@ianseyer ianseyer commented Feb 3, 2025

Fixes #18087, #15751, #10813, #12011, #16556, #20148

As per golang/go#28239, it is the expectation that middleware using net/http is responsible for handling http.AbortHandler errors that are automatically recovered.

In the current situation, any network connectivity blip, despite recovering successfully, results in a panic being written to the logs.

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

wy65701436 and others added 8 commits October 24, 2024 17:38
Signed-off-by: wang yan <wangyan@vmware.com>
Signed-off-by: yminer <yminer@vmware.com>
Signed-off-by: wang yan <wangyan@vmware.com>
Update fr-fr-lang.json (goharbor#21082)

Updated untranslated French strings

Signed-off-by: tostt <tostt@users.noreply.github.com>
Co-authored-by: tostt <tostt@users.noreply.github.com>
since we wil not ship the asc files since v2.12, it needs to remove the stesp to handle signatures.

Signed-off-by: wang yan <wangyan@vmware.com>
Signed-off-by: Daniel Jiang <daniel.jiang@broadcom.com>
Signed-off-by: wang yan <wangyan@vmware.com>
@ianseyer ianseyer requested a review from a team as a code owner February 3, 2025 16:45
@ianseyer ianseyer closed this Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handler crashed with error net/http: abort Handler
8 participants