fix: ensure data_volume isn't surrounded by quotes

[Aletor93]

Comprehensive Summary of your change

I'm generating harbor.yaml file with erb function to_yaml, where strings containing / are quoted. It can't be configured.

When I run ./install.sh script, it fails on docker volume command due to quotes which aren't removed:

prepare base dir is set to /srv/harbor/install
docker: Error response from daemon: create "/srv/harbor/data": "\"/srv/harbor/data\"" includes invalid characters for a local volume name, only "[a-zA-Z0-9][a-zA-Z0-9_.-]" are allowed. If you intended to pass a host directory, use absolute path.
See 'docker run --help'.

After editing the prepare script to remove quotes on data_volume if present, it works like a charm. The sed is already used in other scripts, it shouldn't be a problem to use it.

Issue being fixed

n/a (no issue opened)

Please indicate you've done the following:

• Well Written Title and Summary of the PR
• Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
• Accepted the DCO. Commits without the DCO will delay acceptance.
• Made sure tests are passing and test coverage is added if needed.
• Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

[stonezdj]

The intention is to remove the quote when there is a quote, sometimes the path may contain space, to remove quote will cause problem?

[Aletor93]

The intention is to remove the quote when there is a quote, sometimes the path may contain space, to remove quote will cause problem?

In my opinion, its already impossible to use a path with spaces due to: | awk '{print $NF}'.

Here is a test:

# grep data_volume harbor.yml
data_volume: "/srv/harbor/data directory with space"

# grep '^[^#]*data_volume:' harbor.yml | awk '{print $NF}'
space"

There is no change to expect about this.

[OrlinVasilev]

@Aletor93 what shell are you using ?

[Aletor93]

@Aletor93 what shell are you using ?

For the test made here, I've used bash. It seems to be the shell used inside prepare script.

For a better test case, I've commented my modification on prepare script and added an echo to debug.

data_path=$(grep '^[^#]*data_volume:' $input_dir/harbor.yml | awk '{print $NF}') # | sed 's/"//g')
echo ${data_path}-

Then tested to set data_volume with a path containing spaces: data_volume: "/srv/harbor/data directory with space"

# ./install.sh 
...
[Step 3]: preparing harbor configs ...
prepare base dir is set to /srv/harbor/install
space"-
docker: Error response from daemon: create space": "space\"" includes invalid characters for a local volume name, only "[a-zA-Z0-9][a-zA-Z0-9_.-]" are allowed. If you intended to pass a host directory, use absolute path.
See 'docker run --help'.

I observe that awk get the last part of the string ($NF), using space as its default separator.