-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enlarge the gc workers to 10 #21462
enlarge the gc workers to 10 #21462
Conversation
Signed-off-by: wang yan <wangyan@vmware.com>
68de71c
to
d009366
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What will happen if you have only 5 workers in your system, but the users select 10?
- Maybe this option should be configurable in config or even UI.
- allow the user to specify the worker amount in % up to 55 e.g. fibonacci
1 | 2 | 3 | 5 | 8 | 13 | 21 | 34 | 55 - Also from the UX/UI design perspective, a dropdown for >5
Dropdown: Use when the options are limited (e.g., up to 5-7) and users can quickly scan and select from predefined values.
Example: Choosing between 1, 2, 3.
In your case: Switch from dropdown to an input field with validation for numbers between 1 and 10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
The GC workers, which refer to the number of goroutines, are different from the job service workers. They are two separate concepts. I'm fine with the UI option, so we can submit another PR to update that. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21462 +/- ##
==========================================
+ Coverage 45.36% 46.17% +0.81%
==========================================
Files 244 247 +3
Lines 13333 13883 +550
Branches 2719 2875 +156
==========================================
+ Hits 6049 6411 +362
- Misses 6983 7132 +149
- Partials 301 340 +39
Flags with carried forward coverage won't be shown. Click here to find out more. |
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: