diff --git a/HandRecognizer/models/official/nlp/transformer/data_download.py b/HandRecognizer/models/official/nlp/transformer/data_download.py index e3ce7fc..8d73e75 100644 --- a/HandRecognizer/models/official/nlp/transformer/data_download.py +++ b/HandRecognizer/models/official/nlp/transformer/data_download.py @@ -203,7 +203,26 @@ def download_and_extract(path, url, input_filename, target_filename): # Extract compressed files logging.info("Extracting %s.", compressed_file) with tarfile.open(compressed_file, "r:gz") as corpus_tar: - corpus_tar.extractall(path) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(corpus_tar, path) # Return file paths of the requested files. input_file = find_file(path, input_filename)