-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Data races between initDecoder and initEncoder operations #529
Comments
I also have the same issue |
same |
@toddtreece It seems that your PR caused a regression. I'm currently unable to allocate time to address this, so could you please handle it ? |
@goccy yes, sorry about missing that. i will open a PR to address it tomorrow morning |
2 tasks
k1LoW
added a commit
to k1LoW/runn
that referenced
this issue
Jan 24, 2025
This was referenced Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In v0.10.4, A data race condition has been detected when running tests with
-race
flag.I suspect the following is occurring from this PR (#490 ):
runtime.AnalyzeTypeAddr()
is being called in bothinitDecoder
andinitEncoder
.sync.Once
, sinceinitEncoderOnce
andinitDecoderOnce
are separate variables, concurrent calls toinitEncoder
andinitDecoder
result in race conditions inruntime.AnalyzeTypeAddr()
operations.In our project, tests that simultaneously use
json.Marshal
andjson.Unmarshal
have become flaky.The text was updated successfully, but these errors were encountered: