-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add memory function accessors #468
Conversation
memory function accessors + tests |
I removed the function I mistakenly added earlier, it should work now. |
This is off to a great start, and I especially appreciate that you updated the test macros to use the new functions. A few things to help you get this over the finish line: don't forget to add the functions to |
Thanks for the tip. I wrote functions in stumpless.def and wrote functions in extern “C” memory.h . I also changed the tests, removed the check for null because get functions do not return null, added 3 new ones that custom functions correctly replace standard functions and can be retrieved. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## latest #468 +/- ##
==========================================
+ Coverage 90.59% 90.60% +0.01%
==========================================
Files 47 47
Lines 4379 4385 +6
Branches 587 587
==========================================
+ Hits 3967 3973 +6
Misses 279 279
Partials 133 133 ☔ View full report in Codecov by Sentry. |
I added new 3 functions stumpless_get_malloc(), stumpless_get_free(), stumpless_get_realloc(). And added pointer and null tests to them. Is this enough?