Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation of all german messages (#117) #462

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

Testspieler09
Copy link
Contributor

@Testspieler09 Testspieler09 commented Oct 6, 2024

Translated all english messages marked as // todo translation
Referring to issue: #117

@Testspieler09 Testspieler09 changed the title Translation of all german messages (ä Translation of all german messages (#117) Oct 6, 2024
Copy link

codecov bot commented Oct 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.54%. Comparing base (1bd3333) to head (a3e9c08).
Report is 3 commits behind head on latest.

Additional details and impacted files
@@            Coverage Diff             @@
##           latest     #462      +/-   ##
==========================================
+ Coverage   90.35%   90.54%   +0.19%     
==========================================
  Files          47       47              
  Lines        4374     4379       +5     
  Branches      586      587       +1     
==========================================
+ Hits         3952     3965      +13     
+ Misses        287      280       -7     
+ Partials      135      134       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@goatshriek goatshriek added the l10n localization of stumpless label Oct 7, 2024
@goatshriek goatshriek self-assigned this Oct 7, 2024
Copy link
Owner

@goatshriek goatshriek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for updating this translation - there have been quite a few new strings since it was first done.

Only a few lines that need to be trimmed to be less than 80 characters: they are noted in the "Static Analysis" CI run. Once those are fixed up this should be good to go!

@Testspieler09
Copy link
Contributor Author

Thank you for the feedback I shortened the lines now (a3e9c08). If there is anything else I can do to improve this PR let me know.

@goatshriek goatshriek merged commit ff89432 into goatshriek:latest Oct 7, 2024
56 checks passed
@goatshriek goatshriek added the hacktoberfest-accepted accepted work that is valid for hacktoberfest label Oct 7, 2024
@Testspieler09 Testspieler09 deleted the translation_de branch October 7, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted accepted work that is valid for hacktoberfest l10n localization of stumpless
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants