Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #424

Closed
wants to merge 1 commit into from
Closed

Update README.md #424

wants to merge 1 commit into from

Conversation

codehooni
Copy link
Contributor

There was one mistake I made in the contribution process. The Korean flag was not properly displayed in the README.md file. 🇰🇷 was incorrectly marked as :ko: Please change it again. I'm sorry for the inconvenience.

@goatshriek
Copy link
Owner

It is no trouble at all, thanks for submitting a fix.

I hadn't actually considered putting the code points directly into the README before, and I think this actually makes more sense than using the GitHub markdown name, which has confused myself and others before as well. I will probably move the README to do this at some point in the future.

For now to keep everything consistent, could you please update your change to use :kr: instead? This should render properly as 🇰🇷 .

@goatshriek
Copy link
Owner

If you'd like, I can also make the change of all flags to the direct unicode characters as part of #425, in which case you can simply close this pull request. Either way forward is fine with me.

@codehooni
Copy link
Contributor Author

I think it would be nice if all the flags were changed to Unicode directly at once as part of #425 work, so I'll close that PR!

@codehooni codehooni closed this Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants