Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add memory function accessors #447

Closed
goatshriek opened this issue Sep 26, 2024 · 6 comments
Closed

add memory function accessors #447

goatshriek opened this issue Sep 26, 2024 · 6 comments
Assignees
Labels
enhancement new features or improvements good first issue something that would be simple for a newcomer to stumpless to work on help wanted external contributations encouraged

Comments

@goatshriek
Copy link
Owner

While stumpless currently provides a way to control the functions used to manage dynamic memory, it does not provide matching functions to retrieve the current settings. This may be useful to library users, and would also make some of the testing code cleaner as well.

General Approach

There are a few details left out of the following outline, for you to fill in as you encounter them. If you find you need help, please ask here or on the project gitter and someone can help you get past the stumbling block.

First, read this section of the development documentation on adding new functions. Once you understand how this process works, you'll be ready to define the new functions.

Add your three new functions to include/stumpless/memory.h and the corresponding source file. You should also add tests for your new functions in test/function/memory.cpp.

Finally, update the memory counting macros used in benchmark tests to use your new functions. These are defined in include/test/helper/memory_counter.hpp. They currently assume that the settings to restore are the standard library functions, but this may not always be the case. Change the INIT_MEMORY_COUNTER macro to use your new functions instead of making this assumption.

@goatshriek goatshriek added enhancement new features or improvements help wanted external contributations encouraged good first issue something that would be simple for a newcomer to stumpless to work on hacktoberfest labels Sep 26, 2024
@tertyshnyi
Copy link
Contributor

Hi, I'd like to do this task. Can you assign it to me?

@goatshriek
Copy link
Owner Author

Sure, good luck!

@tertyshnyi
Copy link
Contributor

изображение_2024-10-11_143617058

Can you help explain what the problem might be?

@goatshriek
Copy link
Owner Author

What is the problem? The screenshot seems to simply show the entry example running.

@tertyshnyi
Copy link
Contributor

Thank you for answering. If that's the way it's supposed to be, then I'll get to the task at hand.

@goatshriek
Copy link
Owner Author

Closed by #468.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new features or improvements good first issue something that would be simple for a newcomer to stumpless to work on help wanted external contributations encouraged
Projects
None yet
Development

No branches or pull requests

2 participants