Add checking and testing for invalid privals in stumpless-get-priorit…

…y-string
goatshriek · Nov 9, 2024 · b22d9f5 · b22d9f5
1 parent c0fb2e4
commit b22d9f5
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/src/prival.c b/src/prival.c
@@ -66,6 +66,10 @@ stumpless_get_priority_string( int prival ) {
   size_t priority_string_size;
   char* priority_string;
 
+  if ((prival & 0xff) != prival) {
+    return NULL;
+  }
+
   facility = stumpless_get_facility_string( get_facility( prival ) );
   severity = stumpless_get_severity_string( get_severity( prival ) );
 

diff --git a/test/function/prival.cpp b/test/function/prival.cpp
@@ -132,4 +132,21 @@ namespace {
 
     free( ( void * ) result );
   }
+
+  TEST(GetPriorityString, InvalidPrivals) {
+    int prival;
+    const char *result;
+
+    prival = -1;
+    result = stumpless_get_priority_string( prival );
+    EXPECT_STREQ( result, NULL );
+
+    free( ( void * ) result );
+
+    prival = 0x100;
+    result = stumpless_get_priority_string( prival );
+    EXPECT_STREQ( result, NULL );
+
+    free( ( void * ) result );
+  }
 }