Update new fakemachine and shell escaping #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer fakemachines adds shell escaping to the arguments passed into it. Which means that the minimal escaping (by quoting) in debos ends up actually adding quotes to the arguments as it gets escaped Fixes #141 Signed-off-by: Sjoerd Simons <sjoerd@collabora.com>
To help using variables as part of shell command add a escape template helper function which escapes the variable properly for shell usage Signed-off-by: Sjoerd Simons <sjoerd@collabora.com>
Test both escaping variables passed into debos and the new escaping template function Signed-off-by: Sjoerd Simons <sjoerd@collabora.com>
sjoerdsimons
force-pushed
the
template-var-escaping
branch
from
20a384d to
5ca74b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft for now until fakemachine v0.0.7 is released