Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change mech dependency of OLAS from branch "gabriel/olas-deps" to "main" #281

Closed
gabrielfior opened this issue Jun 18, 2024 · 1 comment · Fixed by #285
Closed

Change mech dependency of OLAS from branch "gabriel/olas-deps" to "main" #281

gabrielfior opened this issue Jun 18, 2024 · 1 comment · Fixed by #285

Comments

@gabrielfior
Copy link
Contributor

We want to have the PMAT dependency on Olas pointing to the main branch, instead of the gabriel/olas-deps branch (as in this file).

Since we are using a forked repo (https://github.com/gabrielfior/subgrounds/) as dependency on branch gabriel/olas-deps and that cannot be published on PyPI (see error below), we need to wait for the subgrounds new version (1.9.*) to be released (should happen soon).

Error

HTTP Error 400: Can't have direct dependency: subgrounds@ git+https://github.com/gabrielfior/subgrounds@main. See https://packaging.python.org/specifications/core-metadata for more information.

Implementation:

  • Checkout gabriel/olas-deps branch
  • Specify subgrounds new version (see latest release, should be 1.9.x)
  • Open PR, merge
@gabrielfior
Copy link
Contributor Author

gabrielfior commented Jun 19, 2024

Remaining action items

  • PR opened for subgrounds to fix dependencies (Relaxed pytest-asyncio dependency 0xPlaygrounds/subgrounds#58)
  • Once PR 58 above is merged, change pyproject.toml on PMAT to point to new release (likely 1.9.1)
  • Try building/publishing PMAT with new dependency manually, make sure it works
  • Open PR on PMAT with new subgrounds dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant