Skip to content

Commit

Permalink
LibWeb: Prevent double page title update in DOM::Document
Browse files Browse the repository at this point in the history
This ad-hoc code informs the client of a potentially changed page title.
But because we always update the title element (either the SVG or HTML
title) the client was already informed, causing the code to run twice.
  • Loading branch information
gmta committed Feb 3, 2025
1 parent 0f17ad9 commit 9612e77
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions Libraries/LibWeb/DOM/Document.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1029,9 +1029,6 @@ WebIDL::ExceptionOr<void> Document::set_title(String const& title)
return {};
}

if (browsing_context() == &page().top_level_browsing_context())
page().client().page_did_change_title(title.to_byte_string());

return {};
}

Expand Down

0 comments on commit 9612e77

Please sign in to comment.