LibWeb: Add PointerEvent.getCoalescedEvents() and .getPredictedEvents()

Fixes at least 4 WPT subtests in /pointerevents.
gmta · Oct 18, 2024 · 8f2f744 · 8f2f744
1 parent ecd0090
commit 8f2f744
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 4 deletions.
diff --git a/Userland/Libraries/LibWeb/UIEvents/PointerEvent.cpp b/Userland/Libraries/LibWeb/UIEvents/PointerEvent.cpp
@@ -26,6 +26,8 @@ PointerEvent::PointerEvent(JS::Realm& realm, FlyString const& type, PointerEvent
     , m_pointer_type(event_init.pointer_type)
     , m_is_primary(event_init.is_primary)
     , m_persistent_device_id(event_init.persistent_device_id)
+    , m_coalesced_events(event_init.coalesced_events)
+    , m_predicted_events(event_init.predicted_events)
 {
 }
 

diff --git a/Userland/Libraries/LibWeb/UIEvents/PointerEvent.h b/Userland/Libraries/LibWeb/UIEvents/PointerEvent.h
@@ -25,6 +25,8 @@ struct PointerEventInit : public MouseEventInit {
     String pointer_type;
     bool is_primary { false };
     WebIDL::Long persistent_device_id { 0 };
+    AK::Vector<JS::Handle<PointerEvent>> coalesced_events;
+    AK::Vector<JS::Handle<PointerEvent>> predicted_events;
 };
 
 // https://w3c.github.io/pointerevents/#pointerevent-interface
@@ -51,6 +53,8 @@ class PointerEvent : public MouseEvent {
     String const& pointer_type() const { return m_pointer_type; }
     bool is_primary() const { return m_is_primary; }
     WebIDL::Long persistent_device_id() const { return m_persistent_device_id; }
+    AK::Vector<JS::Handle<PointerEvent>> get_coalesced_events() const { return m_coalesced_events; };
+    AK::Vector<JS::Handle<PointerEvent>> get_predicted_events() const { return m_predicted_events; };
 
     // https://w3c.github.io/pointerevents/#dom-pointerevent-pressure
     // For hardware and platforms that do not support pressure, the value MUST be 0.5 when in the active buttons state and 0 otherwise.
@@ -125,6 +129,12 @@ class PointerEvent : public MouseEvent {
     // A unique identifier for the pointing device.
     // https://w3c.github.io/pointerevents/#dom-pointerevent-persistentdeviceid
     WebIDL::Long m_persistent_device_id { 0 };
+
+    // https://w3c.github.io/pointerevents/#dom-pointerevent-getcoalescedevents
+    AK::Vector<JS::Handle<PointerEvent>> m_coalesced_events;
+
+    // https://w3c.github.io/pointerevents/#dom-pointerevent-getpredictedevents
+    AK::Vector<JS::Handle<PointerEvent>> m_predicted_events;
 };
 
 }

diff --git a/Userland/Libraries/LibWeb/UIEvents/PointerEvent.idl b/Userland/Libraries/LibWeb/UIEvents/PointerEvent.idl
@@ -15,8 +15,8 @@ dictionary PointerEventInit : MouseEventInit {
     DOMString pointerType = "";
     boolean isPrimary = false;
     long persistentDeviceId = 0;
-    // FIXME: sequence<PointerEvent> coalescedEvents = [];
-    // FIXME: sequence<PointerEvent> predictedEvents = [];
+    sequence<PointerEvent> coalescedEvents = [];
+    sequence<PointerEvent> predictedEvents = [];
 };
 
 // https://w3c.github.io/pointerevents/#pointerevent-interface
@@ -36,6 +36,6 @@ interface PointerEvent : MouseEvent {
     readonly attribute DOMString pointerType;
     readonly attribute boolean isPrimary;
     readonly attribute long persistentDeviceId;
-    [FIXME, SecureContext] sequence<PointerEvent> getCoalescedEvents();
-    [FIXME] sequence<PointerEvent> getPredictedEvents();
+    [SecureContext] sequence<PointerEvent> getCoalescedEvents();
+    sequence<PointerEvent> getPredictedEvents();
 };