Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

psycopg2 as a dependency #37

Closed
louis77 opened this issue Jun 3, 2020 · 2 comments
Closed

psycopg2 as a dependency #37

louis77 opened this issue Jun 3, 2020 · 2 comments

Comments

@louis77
Copy link

louis77 commented Jun 3, 2020

Installing queries via pip install psycopg2 as a dependency. However on many platforms now psycopg2-binary package must be used because of lack of PG dev packages available. For instance, AWS Lambda, Azure Functions etc.

Therefore I believe that either psycopg2 should be removed as a direct dependency and let the user manually add the approprate package or offer a queries-binary variant.
@stephane-klein
Copy link

Same issue for me @gmr

stephane-klein added a commit to spacefill/queries that referenced this issue Nov 4, 2020
@stephane-klein
Remove psycopg2 in package requirements gmr#37
1cd9ac7 
Why?  To leave the chose to use psycopg2-binary, psycopg2 or psycopg2cffi
@stephane-klein
Copy link

@gmr what do you think about this Pull Request #39 ?

stephane-klein added a commit to spacefill/queries that referenced this issue Nov 4, 2020
@stephane-klein
Remove psycopg2 in package requirements gmr#37
7484af0 
Why?  To leave the chose to use psycopg2-binary, psycopg2 or psycopg2cffi
@louis77 louis77 closed this as completed Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@louis77 @stephane-klein