Nanobind density changes #1307
Merged
Nanobind density changes #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation of `reduceAndReturn` does not allow the previous pattern of calling `prepare` in `reduce`. In the new implemtnation, `reduceAndReturn` will return the OLD array even after the new one is created. The solution is to override `reset`. In subclasses of `BondHistogramCompute`, `reset` *must* call the base class implemtnation which resets `m_historgram`. The subclass must then make new shared arrays that are specific to that subclass. Lastly, the arrays must also be initialized in the constructor to allow for the user to construct the class and use it without calling `reset` first.
joaander
force-pushed
the
nanobind_density_changes
branch
from
ae59028 to
fda237d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports density module to nanobind.
Description
All classes have been ported using nanobind as interface instead of cython.
Motivation and Context
Part of nanobind porting initiative.
How Has This Been Tested?
All current tests pass.
Types of changes
Checklist: