Skip to content

Commit 2c0b56c

Browse files
RubenGeoRubenaberonni
authored
PR template (#16)
* PR template Signed-off-by: Ruben <vandervalk@geoit.nl> * Update .github/PULL_REQUEST_TEMPLATE.md Co-authored-by: Domenico Gemoli <dgemoli@redcross.nl> --------- Signed-off-by: Ruben <vandervalk@geoit.nl> Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: Domenico Gemoli <dgemoli@redcross.nl>
1 parent afca689 commit 2c0b56c

File tree

2 files changed

+8
-288
lines changed

2 files changed

+8
-288
lines changed

.github/PULL_REQUEST_TEMPLATE.md

+8-43
Original file line numberDiff line numberDiff line change
@@ -1,47 +1,12 @@
1-
<!--
2-
😀 Wonderful! Thank you for opening a pull request for TypeORM.
1+
AB#XXXX <!--- Replace this with a reference to a devops issue -->
32

4-
Please fill in the information below to expedite the review
5-
and (hopefully) merge of your change.
3+
## Describe your changes
64

7-
If unsure about something.. just do as best as you're able,
8-
or reach out through our community support channels!
9-
https://github.com/typeorm/typeorm/blob/master/docs/support.md
10-
-->
5+
<!--- Add a brief description of your changes - not in-depth because the bulk of the description should be in the task on DevOps. -->
116

12-
### Description of change
7+
## Checklist before requesting a review
138

14-
<!--
15-
Please be clear and concise what the change is intended to do,
16-
why this change is needed, and how you've verified that it
17-
corrects what you intended.
18-
19-
In some cases it may be helpful to include the current behavior
20-
and the new behavior.
21-
22-
If the change is related to an open issue, you can link it here.
23-
If you include `Fixes #0000` (replacing `0000` with the issue number)
24-
when this is merged it will automatically mark the issue as fixed and
25-
close it.
26-
-->
27-
28-
29-
### Pull-Request Checklist
30-
31-
<!--
32-
Please make sure to review and check all of the following.
33-
34-
If an item is not applicable, you can add "N/A" to the end.
35-
-->
36-
37-
- [ ] Code is up-to-date with the `master` branch
38-
- [ ] `npm run format` to apply prettier formatting
39-
- [ ] `npm run test` passes with this change
40-
- [ ] This pull request links relevant issues as `Fixes #0000`
41-
- [ ] There are new or updated unit tests validating the change
42-
- [ ] Documentation has been updated to reflect this change
43-
- [ ] The new commits follow conventions explained in [CONTRIBUTING.md](https://github.com/typeorm/typeorm/blob/master/CONTRIBUTING.md)
44-
45-
<!--
46-
🎉 Thank you for contributing and making TypeORM even better!
47-
-->
9+
- [ ] I have performed a self-review of my code
10+
- [ ] I have added tests wherever relevant
11+
- [ ] I have made sure that all automated checks pass before requesting a review
12+
- [ ] I do not need any deviation from our [PR guidelines](https://github.com/global-121/121-platform/blob/main/docs/CONTRIBUTING.md)

CONTRIBUTING.md

-245
This file was deleted.

0 commit comments

Comments
 (0)