portalicious: fix validation on change password page #6449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (1)
- interfaces/Portalicious/src/app/services/auth/strategies/basic-auth/basic-auth.change-password.component.html: Language not supported
AB#30007 I had a look at a lot of forms, and I think with the theming efforts the consistency around validation is there now. This was the only scenario that was a bit funky, but it's also the only page where we're using ValidatorFn (because of multi-field validation) so it's needs this extra nudge.
aberonni
force-pushed
the
aberonni/portalicious-change-password-validation
branch
from
30fe166 to
e0c4a93
Compare
arsforza
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AB#30007
I had a look at a lot of forms, and I think with the theming efforts the consistency around validation is there now.
This was the only scenario that was a bit funky, but it's also the only page where we're using ValidatorFn (because of multi-field validation) so it needs this extra nudge.
Checklist before requesting a review
Portalicious preview deployment
https://lively-river-04adce503-6449.westeurope.5.azurestaticapps.net