Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added warning for automatic translations #2966

Merged
merged 9 commits into from
Jul 10, 2024
Merged

Added warning for automatic translations #2966

merged 9 commits into from
Jul 10, 2024

Conversation

akanshaaa19
Copy link
Member

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024 •
edited
Loading

🚀 Deployed on https://deploy-preview-2966--glific-frontend.netlify.app

@github-actions github-actions bot temporarily deployed to pull request July 9, 2024 09:06 Inactive
@codecov Codecov
Copy link

codecov bot commented Jul 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.96970% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.78%. Comparing base (4f4a496) to head (7250be7).

Files Patch % Lines
...ractiveMessage/TranslateButton/TranslateButton.tsx 93.33% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2966      +/-   ##
==========================================
+ Coverage   79.41%   79.78%   +0.37%     
==========================================
  Files         319      319              
  Lines       10136    10159      +23     
  Branches     2167     2174       +7     
==========================================
+ Hits         8049     8105      +56     
+ Misses       1450     1416      -34     
- Partials      637      638       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cypress Cypress
Copy link

cypress bot commented Jul 9, 2024 •
edited
Loading

1 flaky test on run #4949 ↗︎

0 174 0 0 Flakiness 1

Details:

Merge 7250be7 into 4f4a496...
Project: Glific Commit: 2729acb9dd ℹ️
Status: Passed Duration: 25:59 💡
Started: Jul 10, 2024 9:23 AM Ended: Jul 10, 2024 9:49 AM
Flakiness  cypress/e2e/staffmanagement/StaffManagement.spec.ts • 1 flaky test

View Output

Test Artifacts
Staff Management > should redirect to staff management page Test Replay Screenshots

Review all test suite changes for PR #2966 ↗︎

@github-actions github-actions bot temporarily deployed to pull request July 9, 2024 10:14 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 10, 2024 05:39 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 10, 2024 06:20 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 10, 2024 06:24 Inactive
@akanshaaa19 akanshaaa19 requested a review from mdshamoon July 10, 2024 08:14
@github-actions github-actions bot temporarily deployed to pull request July 10, 2024 09:15 Inactive
mdshamoon
mdshamoon approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@mdshamoon mdshamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mdshamoon mdshamoon merged commit 23c8ad1 into master Jul 10, 2024
13 of 14 checks passed
@mdshamoon mdshamoon deleted the enhancement/translations-warning branch July 10, 2024 12:02
@AkhileshNegi AkhileshNegi mentioned this pull request Jul 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdshamoon mdshamoon mdshamoon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akanshaaa19 @mdshamoon