Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a checkbox for re-categorisation of HSM template categories #2962

Merged
merged 5 commits into from
Jul 8, 2024

Conversation

akanshaaa19
Copy link
Member

No description provided.

Copy link

github-actions bot commented Jul 5, 2024

@github-actions github-actions bot temporarily deployed to pull request July 5, 2024 04:22 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 5, 2024 04:40 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 5, 2024 04:43 Inactive
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.20%. Comparing base (a4ba002) to head (1d41f7b).

Files Patch % Lines
src/containers/Template/Form/Template.tsx 60.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2962   +/-   ##
=======================================
  Coverage   79.20%   79.20%           
=======================================
  Files         318      318           
  Lines        9969     9975    +6     
  Branches     2135     2137    +2     
=======================================
+ Hits         7896     7901    +5     
- Misses       1429     1430    +1     
  Partials      644      644           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akanshaaa19 akanshaaa19 linked an issue Jul 5, 2024 that may be closed by this pull request
@akanshaaa19 akanshaaa19 requested a review from kurund July 5, 2024 04:49
Copy link

cypress bot commented Jul 5, 2024

3 flaky tests on run #4910 ↗︎

0 174 0 0 Flakiness 3

Details:

Merge 1d41f7b into a4ba002...
Project: Glific Commit: 1c731677ab ℹ️
Status: Passed Duration: 25:07 💡
Started: Jul 5, 2024 4:51 AM Ended: Jul 5, 2024 5:16 AM
Flakiness  cypress/e2e/chat/ChatCollection.spec.ts • 3 flaky tests

View Output

Test Artifacts
ChatCollection > should send the message to collection Test Replay Screenshots
ChatCollection > should send the emoji to collection Test Replay Screenshots
ChatCollection > should send attachment to collection - Image Test Replay Screenshots

Review all test suite changes for PR #2962 ↗︎

Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@github-actions github-actions bot temporarily deployed to pull request July 8, 2024 06:59 Inactive
@kurund kurund merged commit 37168cf into master Jul 8, 2024
10 of 11 checks passed
@kurund kurund deleted the enhancement/hsm-category-button branch July 8, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HSM Template: create a button for allow template category change
2 participants