Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #2955

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Cleanup #2955

merged 1 commit into from
Jul 3, 2024

Conversation

akanshaaa19
Copy link
Member

No description provided.

@akanshaaa19 akanshaaa19 requested a review from kurund July 2, 2024 05:28
Copy link

github-actions bot commented Jul 2, 2024

@github-actions github-actions bot temporarily deployed to pull request July 2, 2024 05:30 Inactive
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.23%. Comparing base (775dab1) to head (2428e01).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2955      +/-   ##
==========================================
+ Coverage   79.20%   79.23%   +0.03%     
==========================================
  Files         318      318              
  Lines        9976     9969       -7     
  Branches     2135     2135              
==========================================
- Hits         7901     7899       -2     
+ Misses       1431     1427       -4     
+ Partials      644      643       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Jul 2, 2024

2 flaky tests on run #4894 ↗︎

0 174 0 0 Flakiness 2

Details:

Merge 2428e01 into 775dab1...
Project: Glific Commit: 715bccd9c3 ℹ️
Status: Passed Duration: 25:36 💡
Started: Jul 2, 2024 5:38 AM Ended: Jul 2, 2024 6:03 AM
Flakiness  cypress/e2e/chat/ChatCollection.spec.ts • 2 flaky tests

View Output

Test Artifacts
ChatCollection > should send the message to collection Test Replay Screenshots
ChatCollection > should send attachment to collection - Image Test Replay Screenshots

Review all test suite changes for PR #2955 ↗︎

Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@kurund kurund merged commit a4ba002 into master Jul 3, 2024
13 of 14 checks passed
@kurund kurund deleted the cleanup branch July 3, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants