Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HSM template new UI #2915

Merged
merged 53 commits into from
Jul 10, 2024
Merged

HSM template new UI #2915

merged 53 commits into from
Jul 10, 2024

Conversation

akanshaaa19
Copy link
Member

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 8, 2024 •
edited
Loading

🚀 Deployed on https://deploy-preview-2915--glific-frontend.netlify.app

@github-actions github-actions bot temporarily deployed to pull request June 8, 2024 17:53 Inactive
@cypress Cypress
Copy link

cypress bot commented Jun 8, 2024 •
edited
Loading

Passing run #4955 ↗︎

0 174 0 0 Flakiness 0

Details:

Merge 7c00d86 into b2b8a5f...
Project: Glific Commit: 42a33ce860 ℹ️
Status: Passed Duration: 25:37 💡
Started: Jul 10, 2024 4:26 PM Ended: Jul 10, 2024 4:51 PM

Review all test suite changes for PR #2915 ↗︎

@github-actions github-actions bot temporarily deployed to pull request June 17, 2024 08:50 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 17, 2024 10:12 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 19, 2024 15:00 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 21, 2024 04:13 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 23, 2024 13:15 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 23, 2024 13:29 Inactive
@akanshaaa19 akanshaaa19 requested a review from kurund June 23, 2024 13:32
@github-actions github-actions bot temporarily deployed to pull request July 5, 2024 13:09 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 5, 2024 13:19 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 5, 2024 14:02 Inactive
mdshamoon
mdshamoon reviewed Jul 5, 2024
View reviewed changes
Copy link
Member

@mdshamoon mdshamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Just check for the issue with null shortcodes.

@github-actions github-actions bot temporarily deployed to pull request July 8, 2024 08:20 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 8, 2024 10:37 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 9, 2024 13:10 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 10, 2024 08:57 Inactive
@akanshaaa19 akanshaaa19 requested a review from mdshamoon July 10, 2024 09:56
mdshamoon
mdshamoon approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@mdshamoon mdshamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 .

@github-actions github-actions bot temporarily deployed to pull request July 10, 2024 16:09 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 10, 2024 16:11 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 10, 2024 16:18 Inactive
@akanshaaa19 akanshaaa19 merged commit f4a3646 into master Jul 10, 2024
12 of 14 checks passed
@akanshaaa19 akanshaaa19 deleted the enhancement/hsm-templates branch July 10, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdshamoon mdshamoon mdshamoon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akanshaaa19 @mdshamoon