Collection management

[akanshaaa19]

No description provided.

[github-actions]

🚀 Deployed on https://deploy-preview-2908--glific-frontend.netlify.app

[cypress]

2 failed tests on run #4916 ↗︎

2

158

0

14

0

Details:

Merge 18b362b into 37168cf...
Project: Glific	Commit: 91b13f7dfc ℹ️
Status: Failed	Duration: 23:38 💡
Started: Jul 8, 2024 7:12 AM	Ended: Jul 8, 2024 7:35 AM

  chat/ChatCollection.spec.ts • 1 failed test

View Output

Test		Artifacts
ChatCollection > should send the message to collection		Test Replay Screenshots

  roles/staff/chat/ChatCollection.spec.ts • 1 failed test

View Output

Test		Artifacts
Role - Staff - ChatCollection > should send the message to collection		Test Replay Screenshots

Review all test suite changes for PR #2908 ↗︎

[codecov]

Codecov Report

Attention: Patch coverage is 88.40580% with 16 lines in your changes missing coverage. Please review.

Project coverage is 79.41%. Comparing base (b6c8217) to head (3d716d4).

Files	Patch %	Lines
src/containers/List/List.tsx	64.70%	5 Missing and 1 partial ⚠️
src/components/UI/Pager/Pager.tsx	69.23%	3 Missing and 1 partial ⚠️
.../WaGroups/GroupCollections/GroupCollectionList.tsx	90.24%	2 Missing and 2 partials ⚠️
...t/ChatMessages/AddToCollection/AddToCollection.tsx	83.33%	0 Missing and 1 partial ⚠️
...iners/Collection/CollectionList/CollectionList.tsx	92.30%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2908      +/-   ##
==========================================
+ Coverage   79.35%   79.41%   +0.05%     
==========================================
  Files         319      319              
  Lines       10081    10136      +55     
  Branches     2159     2167       +8     
==========================================
+ Hits         8000     8049      +49     
- Misses       1441     1450       +9     
+ Partials      640      637       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kurund]

• Can you please fix the alignment for the select all checkbox, it should be in line with the listing checkboxes.

• Contact is still listed after deletion on the contact Collection listing

• On Group collection listing can we replace the add group icon instead of using the add contact icon?

[akanshaaa19]

• Can you please fix the alignment for the select all checkbox, it should be in line with the listing checkboxes.

* Contact is still listed after deletion on the contact Collection listing * On Group collection listing can we replace the add group icon instead of using the add contact icon?

fixed these @kurund

[kurund]

Looks good.