FIX: Partial Loading of Different Screen before the Login Alert Page upon Token Expiration

[Snehil-Shah]

Fixes #2671

Summary

Upon login token expiration, the app now gracefully loads the Login expired alert, instead of partially loading a different page

Test Plan

I actually had some problem in reproducing the login token expiration behaviour in development.
So I took the approach of corrupting the Session's cookie from the devtools by changing the expiration date & renewal token ids to imitate token expiration.
This might be the reason the "Before" recording looks different (and worse) than the recording in the original issue.
I think it should work the same for actual token expiration in production as it relies on the function checkAuthStatusService which primarily checks for token expiration and it handles it pretty well.

I have attached video demos of this issue before & after this PR:

Before (watch till the end)
After

[codecov]

Codecov Report

Attention: Patch coverage is 85.71429% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 76.43%. Comparing base (0801e50) to head (ccbde71).

Files	Patch %	Lines
src/common/utils.ts	62.50%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2683      +/-   ##
==========================================
+ Coverage   76.41%   76.43%   +0.01%     
==========================================
  Files         299      299              
  Lines        9372     9390      +18     
  Branches     2024     2027       +3     
==========================================
+ Hits         7162     7177      +15     
- Misses       1572     1574       +2     
- Partials      638      639       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Snehil-Shah]

Updated Video Preview (Ignore the laggy interface, I am running it on a VM)

[mdshamoon]

Let's discuss this in the call tomorrow.

[mdshamoon]

Please resolve merge conflicts and feedbacks. Otherwise looks good. Will merge after the changes are done

[mdshamoon]

Remove commented test case

[Snehil-Shah]

@mdshamoon I actually needed some help with that, this test and the test above it, are both correct. but I think their mocks are conflicting.
when I comment one of them out, the other one works (so the tests are definitely correct), but both of them don't work together, I tried to resetAllMocks beforeEach, but still am not able to make it work

[mdshamoon]

@Snehil-Shah closing this in favor of #2829. Integration tests were not running against a forked branch. So created a separate branch with these changes. Overall looks good. Merging it after the tests run successfully.

FYI for the test case: vi.mock does not work specific to a test. It updates the module for the whole file. So if you used it twice it picks up the latest one for both the test cases. A better way is to use vi.spy which I have added in the PR.