Add /in command and supporting changes #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows running commands like setwindow or mode in contexts other than the currently focused window. Also adds two new command types, adds focus to the context Args can work with, and reworks a handful of commands to not fetch clientFocus themselves. It also tweaks /list to not use extensionArg anymore. There is still some work that needs doing in support of this one command (as well as future metacommands but never mind): - Tab completion needs to be burned to the ground. - Views (names, masks) need to be changed to respect the override. - `/in #channel-im-not-in masks b` should really just work. ClientCommands don't make sense with /in and can exhibit surprising behavior, and so /in currently rejects them.
Also adjusts the status line to show overridden foci.
Minor changes were made in an earlier commit. These changes are a bit more radical due to subfocuses no longer being "sub"focuses so much. Also changes the application title.
This commit also undoes a decision to forbid client-wide commands from /in. It's simpler this way.
TheDaemoness
force-pushed
the
metacmd-basics
branch
from
5ca8441 to
ccdab4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/inallows running focus-sensitive commands in a different focus than the current one.Also lays some of the groundwork for potential future meta-commands
and adjusts how subfocuses are indicated in the status line and window title.
Caveats:
/masksstill doesn't work on channels that haven't been loaded yet.This will require a minor change to how channel state is handled, namely creating ChannelState for channels one isn't in but marking those states as "stale".
/in.Tab completion needs big changes for this to work (maybe making it the responsibility of the argument spec rather than the command itself?).