Add notes on --downsample-type
#235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbesson
reviewed
Jan 17, 2024
README.md
Outdated
| * Ubuntu 18.04 | ||
| * RHEL 8 | ||
| * Windows 10 | ||
| - expect to see warnings as described in https://github.com/opencv/opencv/issues/20113; these can be ignored |
There was a problem hiding this comment.
This renders at the same level as the previous bullet point. Maybe turn into parentheses?
There was a problem hiding this comment.
19829f1 should fix the bullet points, I just missed a single space. Can put the note about warnings on the same line in parentheses if you think that's clearer though?
sbesson
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed earlier today with @sbesson, @chris-allan, and @mabruce.