fix(eslint): Lint problems

gjsify · Sep 20, 2024 · 1dc8dd0 · 1dc8dd0
1 parent 99709fe
commit 1dc8dd0
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 8 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -13,8 +13,7 @@
         "no-debugger": "off",
         "@typescript-eslint/triple-slash-reference": "off",
         "camelcase": "off",
-        "@typescript-eslint/camelcase": "off",
-        "@typescript-eslint/no-empty-object-type": "off"
+        "@typescript-eslint/camelcase": "off"
     },
     "parserOptions": {
         "requireConfigFile": false,

diff --git a/packages/cli/src/commands/generate.ts b/packages/cli/src/commands/generate.ts
@@ -76,6 +76,7 @@ class TypeScriptFormatter extends Formatter {
                 tabWidth: 4,
             })
         } catch (error) {
+            Logger.warn('[TypeScriptFormatter] Failed to format with prettier, returning original input', error)
             return Promise.resolve(input)
         }
     }

diff --git a/packages/lib/.eslintrc.cjs b/packages/lib/.eslintrc.cjs
@@ -13,8 +13,7 @@ module.exports = {
         'no-debugger': 'off',
         '@typescript-eslint/triple-slash-reference': 'off',
         camelcase: 'off',
-        '@typescript-eslint/camelcase': 'off',
-        '@typescript-eslint/no-empty-object-type': 'off',
+        '@typescript-eslint/camelcase': 'off'
     },
     parserOptions: {
         tsconfigRootDir: __dirname,

diff --git a/packages/lib/src/generators/json.ts b/packages/lib/src/generators/json.ts
@@ -235,7 +235,7 @@ export interface VirtualMethodJson extends NodeJson {
     parameters: ParameterJson[];
     returnType: TypeJson[] | TypeJson;
 }
-export interface MetadataJson extends Json {}
+export type MetadataJson = Json;
 export interface ConstJson extends NodeJson {
     kind: NodeKind.constant;
     name: string;

diff --git a/packages/lib/src/gir/class.ts b/packages/lib/src/gir/class.ts
@@ -1171,7 +1171,7 @@ export class IntrospectedRecord extends IntrospectedBaseClass {
         clazz._copyBaseProperties(this);
 
         if (superType) {
-            clazz.superType;
+            clazz.superType = superType;
         }
 
         clazz._structFor = _structFor;
@@ -1400,7 +1400,6 @@ export class IntrospectedRecord extends IntrospectedBaseClass {
         // "simple" records.
         if (!this.isSimple()) {
             return null;
-            ("not simple");
         }
 
         // Because we may have to recursively check

diff --git a/packages/lib/src/types/gir-instance-parameter.ts b/packages/lib/src/types/gir-instance-parameter.ts
@@ -5,4 +5,4 @@ import * as parser from '@gi.ts/parser'
  * So the callable is surely a method of a class, and this parameter points to the instance of the object.
  * In C++, this would be equivalent to the pointer this which is not passed to the method, in Python it's equivalent to self.
  **/
-export interface GirInstanceParameter extends parser.GirInstanceParameter {}
+export type GirInstanceParameter = parser.GirInstanceParameter