Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix table header row for accessibility (Issue #1299) #1369

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bob-dlc
Copy link

@bob-dlc bob-dlc commented Feb 5, 2025

The accessibility checker built into PowerPoint reports that all tables generated by PPTxGenJS are "Missing Table Header" even the options are set to {autoPage:true, autoPageRepeatHeader:true}. The top row of the table indeed acts like a header visually, but not semantically as far as PowerPoint is concerned. As such, the PPTs fail accessibility testing and are inaccessible for users of assistive technologies such as screen readers.

A simple—and perhaps overly simple—solution was implemented here such that if autoPageRepeatHeader is true, the first row of the table is marked up as a header row when the XML is generated for the PowerPoint file.

Reference issue # 1299 (#1299)

@pgangloff-hbs
Copy link

I reviewed the code, looks fine, I hope this will be merged soon. We need this fix for accessibility. Otherwise the generated PPT has "accessibility warnings" in MS PowerPoint. We'd rather have this PR merged into this project, to avoid creating yet another fork. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants