Feat/maplibre angular 18 #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohamedHamouGisaia
requested review from
sebbousquet,
mbarbet,
QuCMGisaia and
MAudelGisaia
QuCMGisaia
approved these changes
Dec 17, 2024
QuCMGisaia
approved these changes
Jan 7, 2025
MohamedHamouGisaia
force-pushed
the
feat/maplibre_angular_15
branch
from
6ccd313 to
a78891e
Compare
|
MohamedHamouGisaia
force-pushed
the
feat/maplibre_angular_15
branch
from
7d192a3 to
8e5b446
Compare
sebbousquet
approved these changes
Jan 9, 2025
MAudelGisaia
approved these changes
Jan 9, 2025
| import { MapService } from '../../tools/utils'; | ||
| import { ArlasCollaborativesearchService } from '../collaborative-search/arlas.collaborative-search.service'; | ||
| import { AbstractArlasMapGL, ArlasLngLatBounds } from 'arlas-map'; | ||
|
|
||
| /** | ||
| * This service provides methods to apply on the mapboxgl Map object |
| @@ -65,41 +64,7 @@ export class ArlasMapService implements MapService { | |||
| * | |||
| * @param map mapbox map instance | |||
| import { MapService } from '../../tools/utils'; | ||
| import { ArlasCollaborativesearchService } from '../collaborative-search/arlas.collaborative-search.service'; | ||
| import { AbstractArlasMapGL, ArlasLngLatBounds } from 'arlas-map'; | ||
|
|
||
| /** | ||
| * This service provides methods to apply on the mapboxgl Map object | ||
| */ | ||
| @Injectable() | ||
| export class ArlasMapService implements MapService { |
There was a problem hiding this comment.
what ll be the aim of this service ? We should be careful to not implement arlas-map.service's behaviours in this service.
Maybe we should rename this class ?
There was a problem hiding this comment.
this service only propose actions using arlas data, and abstract methods of arlas-map lib
MohamedHamouGisaia
force-pushed
the
feat/maplibre_angular_15
branch
from
b5850ee to
e55b661
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.