Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display correct name for dialog when creating tab for resultlist #1041

Merged
merged 2 commits into from
Jan 28, 2025
Merged

fix: display correct name for dialog when creating tab for resultlist #1041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b844909
fix: display proper name for dialog when creating tab for resultlist
QuCMGisaia Jan 28, 2025
c14d081
fix: space out palette selector title from body
QuCMGisaia Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ules/map-config/components/dialog-palette-selector/dialog-palette-selector.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ h1 {
.palette-gradient {
@extend %palette;

margin-top: 40px;
margin-top: 40px !important;
position: relative;

.parent-gradient-buttons {
Expand Down
10 changes: 5 additions & 5 deletions .../modules/result-list-config/components/global-result-list/global-result-list.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,20 +48,20 @@ export class GlobalResultListComponent implements OnDestroy {
public preview = [];
private editDialogRef: MatDialogRef<EditTabComponent>;

@ViewChild('matTabGroup', { static: false }) private matTabGroup: MatTabGroup;
@ViewChild('matTabGroup', { static: false }) private readonly matTabGroup: MatTabGroup;

public constructor(
public mainFormService: MainFormService,
private collectionService: CollectionService,
private dialog: MatDialog,
private defaultValuesService: DefaultValuesService
private readonly collectionService: CollectionService,
private readonly dialog: MatDialog,
private readonly defaultValuesService: DefaultValuesService
) {
this.listsFa = this.mainFormService.resultListConfig.getResultListsFa();
this.updatePreview();
}

public addResultList() {
const dialogRef = this.dialog.open(InputModalComponent);
const dialogRef = this.dialog.open(InputModalComponent, { data: { title: marker('Tab name') }});
this.newAfterClosedSub = dialogRef.afterClosed().subscribe(name => {
if (name) {
const formGroup = new ResultlistConfigForm(this.mainFormService.getMainCollection(), this.collectionService, name);
Expand Down
Loading