Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feedback shortcut #882

Open
15 of 18 tasks
MohamedHamouGisaia opened this issue May 23, 2023 · 0 comments
Open
15 of 18 tasks

feedback shortcut #882

MohamedHamouGisaia opened this issue May 23, 2023 · 0 comments
Assignees

Comments

@MohamedHamouGisaia
Copy link
Member

MohamedHamouGisaia commented May 23, 2023

Bug:

  • The uid is not used for powerbar (ok for histogram)

Important:

  • use collaborations in shortcuts to retrieve existing filters
  • possibility to get/specify open state to keep this state when moving shortcut in and out of extra filters
    • In order to do so, we plan on adding an output of the shortcut isOpen that will notify the parent component of its opened state, and an input openAtFirst that can tell the shortcut of whether it should be opened. The goal is to keep its state when the shortcut is transfered from the normal display to the more filters one. To further this memory of its previous state, we could add to the url the state of the shortcuts.
  • issue with the map layers

Less important:

  • fix position of histogram tooltip
  • fix typo bae
  • move action of pin to the end
  • to pin a histogram on a conf where no shortcuts were created, 2 clicks are needed
  • creating a new widget doesn't generate correctly a uuid
  • remove detailed histogram
  • replace '-' to avoid confusion with negative values (histograms)
  • FilterShortcutConfiguration n'est pas exporté dans public.api
  • don't update data when shortcuts are closed
  • unused labels array in shortcut component
  • filter icon duplicated for histograms
  • format correctly labels of histogram based on specified parameters
  • shorten numbers in histogram

Questions:

  • What size to consider for the shortcut when displayed ? Size as displayed currently, or size when opened ?
    • Tests to do given the different possibilities of display
  • How to specify in the url which shortcuts are open ?
    • Currently no
  • Do we want the possibility to drag and drop shortcuts ?
    • Too confusing with the more filters
  • Do we want to be able to configure a shortcut's width ? If so how ?
    • Size of widget as input
  • Should it be linked_contributor_id or linkedContributorId ?
    • snake case is the way to go for json schema
  • Should a shortcut be only bars type or should it be the same type as the real analytics ?
    • same as real analytics
@MohamedHamouGisaia MohamedHamouGisaia self-assigned this May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant