Feat:externalize partition filter in ES query #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbarbet
requested review from
sebbousquet,
MohamedHamouGisaia,
sylvaingaudan,
alainbodiguel and
QuCMGisaia
mbarbet
force-pushed
the
feat/partitionFilter
branch
from
3f168af to
ad6ef6d
Compare
| if (f.f != null && !f.f.isEmpty()) { | ||
| CollectionReference collectionReference = fluidSearch.getCollectionReference(); | ||
| if (!filterFHasDateQuery(f, collectionReference) && !StringUtil.isNullOrEmpty(f.dateformat)) { | ||
| throw new BadRequestException("dateformat is specified but no date field is queried in f filter (gt, lt, gte, lte or range operations)"); |
There was a problem hiding this comment.
I find it harsh to raise an exception because the date format is provided and no date is provided. I believe the request is still valid when you add additional unused information.
There was a problem hiding this comment.
This part of code already existed and some IT test specifcally this comportement. I agree to change it but not in this PR.
sylvaingaudan
approved these changes
Jun 3, 2024
alainbodiguel
approved these changes
Jun 3, 2024
arlas-core/src/main/java/io/arlas/server/core/services/ExploreService.java
Show resolved
Hide resolved
MohamedHamouGisaia
approved these changes
Jun 3, 2024
QuCMGisaia
approved these changes
Jun 3, 2024
arlas-core/src/main/java/io/arlas/server/core/impl/elastic/services/ElasticFluidSearch.java
Outdated
Show resolved
Hide resolved
arlas-core/src/main/java/io/arlas/server/core/impl/elastic/services/ElasticFluidSearch.java
Outdated
Show resolved
Hide resolved
ogc-wfs/src/main/java/io/arlas/server/ogc/wfs/services/ElasticWFSToolService.java
Outdated
Show resolved
Hide resolved
mbarbet
force-pushed
the
feat/partitionFilter
branch
from
ad6ef6d to
65abba7
Compare
mbarbet
changed the title
mbarbet
force-pushed
the
feat/partitionFilter
branch
from
a019794 to
cb18e89
Compare
mbarbet
requested review from
MohamedHamouGisaia,
alainbodiguel,
sylvaingaudan and
QuCMGisaia
alainbodiguel
approved these changes
Jun 18, 2024
MohamedHamouGisaia
changed the title
QuCMGisaia
approved these changes
Jul 3, 2024
MohamedHamouGisaia
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We remove the partition-filter header in case it's been set manually