Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some improvement ideas #595

Open
laurent-thiebaud-gisaia opened this issue Jan 21, 2020 · 0 comments
Open

Some improvement ideas #595

laurent-thiebaud-gisaia opened this issue Jan 21, 2020 · 0 comments
Labels
type:enhancement Feature that impacts end-user

Comments

@laurent-thiebaud-gisaia
Copy link
Contributor

laurent-thiebaud-gisaia commented Jan 21, 2020

Few things we could do or try to lake it more perfect:

  • for better readability, some checks can be done with Apache libs e.g.
    if (collectionReference.params.excludeFields != null && !collectionReference.params.excludeFields.isEmpty())
    can be replaced with
    if (StringUtils.isNotEmpty(collectionReference.params.excludeFields))
    or by filtering empty spaces with
    if (StringUtils.isNotBlank(collectionReference.params.excludeFields))
    There is also a CollectionUtil to handle collections...

  • tests are cool, but DatasetTool and CollectionTool with their static methods look outdated. Is it interesting to rewrite them? Is there any value to use https://www.elastic.co/guide/en/elasticsearch/reference/current/integration-tests.html ?

  • The CheckParams doesn't only check the params, it also set some default values. It is ambiguous, maybe the roles can be splitted into 2 classes or the class should be renamed?

  • Some classes a few methods but a lot of code with a huge cyclomatic complexity, this can probably be splitted into multiples classes or/and shorter methods

@laurent-thiebaud-gisaia laurent-thiebaud-gisaia added the type:enhancement Feature that impacts end-user label Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Feature that impacts end-user
Projects
None yet
Development

No branches or pull requests

1 participant