Code scanning fix patches #638
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nojaf
reviewed
Jan 17, 2025
| @@ -44,7 +44,7 @@ let mustAcceptAny (mimeTypes: string list) (optionalErrorHandler: OptionalErrorH | |||
| ) | |||
|
|
|||
| match Option.ofObj (headers.Accept :> _ seq) with | |||
| | Some xs when Seq.map (_.ToString()) xs |> Seq.exists (fun x -> Seq.contains x mimeTypes) -> next ctx | |||
| | Some xs when Seq.map (_.ToString()) xs |> Seq.exists (fun x -> List.contains x mimeTypes) -> next ctx | |||
There was a problem hiding this comment.
Nitpick, you can probably move the ToString inside the Seq.exists.
And I wonder if Sets should be used here. The order of mimeTypes doesn't matter here.
| @@ -55,14 +55,17 @@ module ResponseCaching = | |||
| | Public duration -> tHeaders.CacheControl <- cacheHeader true duration | |||
| | Private duration -> tHeaders.CacheControl <- cacheHeader false duration | |||
|
|
|||
| if vary.IsSome then | |||
| headers.[HeaderNames.Vary] <- StringValues [| vary.Value |] | |||
| match vary with | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the following code scan warnings:
How to test
TODO :: add automated tests for ResponseCaching