Skip to content

Commit

Permalink
Minor refactoring
Browse files Browse the repository at this point in the history
  • Loading branch information
gimesketvirtadieni committed Jun 24, 2018
1 parent 6c7963c commit 17fd3b5
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
6 changes: 3 additions & 3 deletions src/slim/Scheduler.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ namespace slim

Scheduler(const Scheduler&) = delete; // non-copyable
Scheduler& operator=(const Scheduler&) = delete; // non-assignable
Scheduler(Scheduler&& rhs) = default;
Scheduler& operator=(Scheduler&& rhs) = default;
Scheduler(Scheduler&& rhs) = delete; // non-movable
Scheduler& operator=(Scheduler&& rhs) = delete; // non-move-assignable

void setProcessorProxy(conwrap::ProcessorProxy<ContainerBase>* p)
{
Expand Down Expand Up @@ -110,7 +110,7 @@ namespace slim
processorProxyPtr->process([&producer = pipeline.getProducer(), &consumer = pipeline.getConsumer()]
{
// TODO: calculate total chunks per processing quantum
// processing chunks as long as destination is not deferring them AND max chunks per task is not reached AND there are chunks available
// processing chunks as long as consumer is not deferring them AND max chunks per task is not reached AND there are chunks available
auto processed{true};
for (unsigned int count{5}; processed && count > 0 && producer.isAvailable(); count--)
{
Expand Down
1 change: 0 additions & 1 deletion src/slim/conn/tcp/Connection.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ namespace slim
{
onStart();

// TODO: validate result???
acceptor.async_accept(
nativeSocket,
[&](const std::error_code& error)
Expand Down
2 changes: 1 addition & 1 deletion src/slim/conn/udp/Server.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
#include "slim/log/log.hpp"
#include "slim/util/AsyncWriter.hpp"

// TODO: refactor
// TODO: parametrize
#define BUFFER_SIZE 1


Expand Down

0 comments on commit 17fd3b5

Please sign in to comment.