fix: add an explicit check to bound element #1839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1839 +/- ##
=========================================
+ Coverage 100.0% 100.0% +0.1%
=========================================
Files 187 187
Lines 34479 34482 +3
Branches 10253 10254 +1
=========================================
+ Hits 34453 34456 +3
Misses 26 26 ☔ View full report in Codecov by Sentry. |
|
Great thanks :) |
|
no probs. will check up on the upstream to see why they're actually using that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checks that the bound element is not an input with a monkey patched forEach. See ghiscoding/Angular-Slickgrid#1446 (reply in thread)
closes #1835