Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relative file paths. #13

Open
1 of 4 tasks
ghgofort opened this issue Mar 7, 2018 · 1 comment
Open
1 of 4 tasks

Fix relative file paths. #13

ghgofort opened this issue Mar 7, 2018 · 1 comment

Comments

@ghgofort
Copy link
Owner

ghgofort commented Mar 7, 2018

As a developer I find there is a much greater likelihood of breaking something inadvertently when using long relative path names with ../../../ to get to the proper directory location. I would expect for these files to be co-located with the other code files that they correspond to (especially tests).

Needed Changes:

  • - Co-locate test files with the target file, but inside a tests directory.
  • - Create a package.json file for all OCAPI library files (/lib subdirectory).
  • - Add the library as a package to the dependencies of the base project.json file.
    -- This will allow for all of the lib files to be included without needing to traverse up the directory tree before specifying the path of a file that is needed.
  • - Update all references to the lib files to reference them with the new package notation.
@ghgofort
Copy link
Owner Author

Test files have been re-located so that they live with the files that they are testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant