Skip to content

Add support for CDATA nodes #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

czerwinskilukasz1
Copy link

This code used to fail to work (it was returning empty url):

<?xml version="1.0"?>
<methodResponse>
<params>
<param><value><struct>
<member><name>task_id</name>
<value><string>56b539723cac6e76b64bc490</string></value></member>
<member><name>item_id</name>
<value><string>29782764-938a-45a7-a766-4f71b18791d9</string></value></member>
<member><name>url</name>
<value><string><![CDATA[https://example.com:1001/script.blah?date=2016-02-04-T12.36.19-tracks.td&id=40386975&ts=1]]></string></value></member>
</struct></value></param></params></methodResponse>

Now it's returning url: https://example.com:1001/script.blah?date=2016-02-04-T12.36.19-tracks.td&id=40386975&ts=1

@gggeek
Copy link
Owner

gggeek commented Feb 10, 2016

thanks, will look into it not before the weekend

@czerwinskilukasz1
Copy link
Author

Hi, gggeek. How was your weekend?
Did you have a chance to take a look at it?
Let me know if there is anything I could do to make your checking easier.

Thanks!
Łukasz

@gggeek
Copy link
Owner

gggeek commented Feb 28, 2016

Q: why are you having CDATA sections in the first place? Afair, they are not supported in xmlrpc.

(I would have to dig in the mailing list archives for confirmation to be honest, but I seem to recall that using a base64 value is the only supported way to send data that is not xml compliant, eg. binary. I see no reason why an url should not be valid utf8 and would need to be escaped as cdata, though)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants