Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Test case for multiple bindings with different sizes #7360

Merged
merged 2 commits into from
Mar 17, 2025

Conversation

andyleiserson
Copy link
Contributor

@andyleiserson andyleiserson commented Mar 17, 2025

Connections
Test case for #7359 (currently failing)

Description
This test creates two bind groups against the same bind group layout, in the same compute pass, but against two different shaders that have different binding sizes. The first has binding size 8, the second has binding size 4.

Squash or Rebase? Squash

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry.

@andyleiserson andyleiserson requested a review from a team as a code owner March 17, 2025 18:57
@andyleiserson andyleiserson changed the title [tests] Test case for multiple bindings with different sizes (#7359) [tests] Test case for multiple bindings with different sizes Mar 17, 2025
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with nit

@cwfitzgerald cwfitzgerald merged commit 8474132 into gfx-rs:trunk Mar 17, 2025
36 checks passed
@andyleiserson andyleiserson deleted the binding-sizes branch March 17, 2025 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants