Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI failure on Nightly: "error: legacy asm! syntax is no longer supported" #664

Closed
paulkernfeld opened this issue May 22, 2020 · 3 comments
Closed

CI failure on Nightly: "error: legacy asm! syntax is no longer supported" #664

paulkernfeld opened this issue May 22, 2020 · 3 comments
Labels
needs information Further information is requested

Comments

@paulkernfeld
Copy link
Contributor

This is from cargo test, apparently due to the generator crate, brought in via loom. Example CI failure. This is because asm! is being renamed to llvm_asm! (tracking issue).

Possible solutions:

  1. Fix the generator crate
  2. Figure out some way to cfg away the asm! code. I'm not sure if loom even uses that stuff.
  3. Don't run loom on nightly
  4. Ignore the CI failures for now
@paulkernfeld paulkernfeld added the needs information Further information is requested label May 22, 2020
@paulkernfeld paulkernfeld mentioned this issue May 22, 2020
Merged
@kvark
Copy link
Member

kvark commented May 22, 2020

We should probably file it to the generator crate, unless it's filed already.

@paulkernfeld
Copy link
Contributor Author

Fair enough. I made PR Xudong-Huang/generator-rs#20 to fix the issue, so hopefully it should be a matter of waiting until that change is merged and propagated upwards.

@paulkernfeld
Copy link
Contributor Author

Now that generator has released 0.6.21, this is fixed. 👍

kvark pushed a commit to kvark/wgpu that referenced this issue Jun 3, 2021
@bors @cwfitzgerald
[rs] Merge gfx-rs#664
19e5c74 
664: Integrate ETC and ASTC textures in Skybox example r=kvark a=cwfitzgerald

Depends on gfx-rs#1074

Converts skybox example to mip-mapped files in:
 - Bgra8
 - Bc1
 - ETC2
 - ASTC4x4

Looks quite good now with mipmapping and trilinear filtering even at small resolutions.

Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs information Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kvark @paulkernfeld