Various Metal performance optimizations #2185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grovesNL
approved these changes
Jun 28, 2018
| let index = first_binding as usize + i; | ||
| let value = Some((buffer_ptr, b.range.start + offset)); | ||
| if index >= self.state.vertex_buffers.len() { | ||
| debug_assert_eq!(index, self.state.vertex_buffers.len()); |
There was a problem hiding this comment.
How could this assertion fail?
There was a problem hiding this comment.
it shouldn't I'm just being overly careful here (hence, it's a debug assert and not a usual one)
| @@ -821,11 +821,11 @@ impl CommandSink { | |||
| ) where | |||
| I: Iterator<Item = soft::RenderCommand<&'a soft::Own>>, | |||
| { | |||
| //assert!(AutoReleasePool::is_active()); | |||
There was a problem hiding this comment.
this is intentional - we need to make sure there is an active autorelease pool set up by the caller here, but I don't know how to code it yet
| @@ -1653,6 +1653,8 @@ impl com::RawCommandBuffer<Backend> for CommandBuffer { | |||
| T: IntoIterator, | |||
| T::Item: Borrow<SubresourceRange>, | |||
| { | |||
| let _ap = AutoreleasePool::new(); | |||
There was a problem hiding this comment.
possible! my motivation was to avoid 2 autorelease pools during a regular begin_render_pass, so now I removed the inner one and made sure all the callers set up one.
|
CI looks green |
bors bot
added a commit
that referenced
this pull request
Jun 28, 2018
2185: Various Metal performance optimizations r=grovesNL a=kvark Helps #2161 . I'm now getting 80-85 fps on the test run. Aside from Metal, also changes HAL to avoid heap allocation for vertex buffer binding. PR checklist: - [x] `make` succeeds (on *nix) - [x] `make reftests` succeeds - [x] tested examples with the following backends: metal Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps #2161 . I'm now getting 80-85 fps on the test run.
Aside from Metal, also changes HAL to avoid heap allocation for vertex buffer binding.
PR checklist:
makesucceeds (on *nix)make reftestssucceeds