feat: add btc map #262
Open
feat: add btc map #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Overall it seems to work ok, map loads a bit slowly but could just be me. Links cannot be opened, is it just Expo go with this issue?
|
rolznz
reviewed
Feb 20, 2025
| <WebView | ||
| source={{ uri: mapUrl }} | ||
| className="flex-1 bg-blue-100" | ||
| geolocationEnabled |
There was a problem hiding this comment.
should this be based on if the permission was granted?
rolznz
approved these changes
Feb 20, 2025
I think it's broke on BTCMap's end, I faced the same issue on Blink too (they also use BTCMap) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #256
Modal is yet to be added. If location is not allowed it will just show a random location and then can be dragged
Screenshots
Tested on both android and iOS