Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/parallelizing varpro #42

Merged
merged 14 commits into from
Jan 26, 2025
Merged

Feature/parallelizing varpro #42

merged 14 commits into from
Jan 26, 2025

Conversation

geo-ant
Copy link
Owner

@geo-ant geo-ant commented Jan 26, 2025

Add the option of letting varpro perform some calculations in parallel.

@geo-ant
Copy link
Owner Author

geo-ant commented Jan 26, 2025

parallelizing (part of) the computations is marked as experimental in the docs, since I haven't yet been able to find a usecase where this is actually faster than single-threaded computations.

@geo-ant geo-ant merged commit a9e994a into main Jan 26, 2025
6 checks passed
@geo-ant geo-ant deleted the feature/parallelizing-varpro branch January 26, 2025 20:24
@supertrianguloid
Copy link

supertrianguloid commented Jan 27, 2025

Thanks for this, this is very exciting! I don't know much (anything) about the varpro algorithm, but do you know any types of problem that would theoretically be sped up by running in parallel?

@geo-ant
Copy link
Owner Author

geo-ant commented Jan 27, 2025

Hey, thank you, first of all. I put a big fat caveat in the docs, because right now the answer is no. My benchmarks show that the parallel computations don't actually benefit the examples, quite the opposite unfortunately. Also only a small part of the calculations can be parallelised at all (calculating the Jacobian). Either I haven't found the right example or the threading overhead is just too much. I don't know yet. Please feel free to play with this and report back to me. The code is well tested and produces the same results as the single threaded code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants