Drop epatch command and rework eapply explanation #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update references throughout. Signed-off-by: Ulrich Müller <ulm@gentoo.org>
thesamesam
approved these changes
Apr 21, 2024
mgorny
reviewed
Apr 22, 2024
Comment on lines
96
to
112
| PATCHES=( | ||
| "${FILESDIR}/${P}-destdir.patch" | ||
| "${FILESDIR}/${P}-parallel_build.patch" | ||
| ) |
There was a problem hiding this comment.
Perhaps add some example comments and upstream patch links, to make it clear that we really want people documenting why they apply patches, and where they get them from.
There was a problem hiding this comment.
I've added a reference to the Patches chapter where all these things are explained. IMHO it doesn't make much sense to repeat it here.
There was a problem hiding this comment.
Sure, but let's add some example comments nevertheless, for good measure.
mgorny
reviewed
Apr 22, 2024
Comment on lines
96
to
112
| PATCHES=( | ||
| "${FILESDIR}/${P}-destdir.patch" | ||
| "${FILESDIR}/${P}-parallel_build.patch" | ||
| ) |
There was a problem hiding this comment.
Sure, but let's add some example comments nevertheless, for good measure.
Drop explanation of epatch. Rework the eapply sections and add additional examples. Signed-off-by: Ulrich Müller <ulm@gentoo.org>
Signed-off-by: Ulrich Müller <ulm@gentoo.org>
Signed-off-by: Ulrich Müller <ulm@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take 2, completely reworked (instead of #329 which was too simplistic).